Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/effort/effort.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export async function call(

if (COMMON_HELP_ARGS.includes(args)) {
onDone(
'Usage: /effort [low|medium|high|max|auto]\n\nEffort levels:\n- low: Quick, straightforward implementation\n- medium: Balanced approach with standard testing\n- high: Comprehensive implementation with extensive testing\n- max: Maximum capability with deepest reasoning (Opus 4.6 only)\n- auto: Use the default effort level for your model',
'Usage: /effort [low|medium|high|max|auto]\n\nEffort levels:\n- low: Quick, straightforward implementation\n- medium: Balanced approach with standard testing\n- high: Comprehensive implementation with extensive testing\n- max: Maximum capability with deepest reasoning (Opus 4.6/4.7, DeepSeek V4 Pro)\n- auto: Use the default effort level for your model',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor: separator inconsistency with getEffortLevelDescription('max').

The help text here uses Opus 4.6/4.7, DeepSeek V4 Pro (comma), while getEffortLevelDescription('max') in src/utils/effort.ts (line 276) uses Opus 4.6/4.7/DeepSeek V4 Pro (slash). Pick one for consistency between /effort help and /effort status output.

✏️ Proposed alignment
-      'Usage: /effort [low|medium|high|max|auto]\n\nEffort levels:\n- low: Quick, straightforward implementation\n- medium: Balanced approach with standard testing\n- high: Comprehensive implementation with extensive testing\n- max: Maximum capability with deepest reasoning (Opus 4.6/4.7, DeepSeek V4 Pro)\n- auto: Use the default effort level for your model',
+      'Usage: /effort [low|medium|high|max|auto]\n\nEffort levels:\n- low: Quick, straightforward implementation\n- medium: Balanced approach with standard testing\n- high: Comprehensive implementation with extensive testing\n- max: Maximum capability with deepest reasoning (Opus 4.6/4.7, DeepSeek V4 Pro)\n- auto: Use the default effort level for your model',

(or update line 276 in src/utils/effort.ts to match — pick whichever style you prefer.)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/commands/effort/effort.tsx` at line 172, The help text for /effort uses a
comma in the "max" description while getEffortLevelDescription('max') in
src/utils/effort.ts uses a slash; make them consistent by choosing one separator
and updating the other to match: either change the string in
src/commands/effort/effort.tsx (the usage/help message) to use "Opus
4.6/4.7/DeepSeek V4 Pro" or update getEffortLevelDescription's 'max' return
value to "Opus 4.6/4.7, DeepSeek V4 Pro" so both the /effort help and the
getEffortLevelDescription('max') output are identical.

)
return
}
Expand Down
10 changes: 8 additions & 2 deletions src/utils/effort.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ export function modelSupportsEffort(model: string): boolean {
if (
m.includes('opus-4-7') ||
m.includes('opus-4-6') ||
m.includes('sonnet-4-6')
m.includes('sonnet-4-6') ||
m.includes('deepseek-v4-pro')
) {
return true
}
Expand All @@ -57,11 +58,16 @@ export function modelSupportsEffort(model: string): boolean {

// @[MODEL LAUNCH]: Add the new model to the allowlist if it supports 'max' effort.
// Per API docs, 'max' is Opus 4.6/4.7 only for public models — other models return an error.
// However, DeepSeek V4 Pro also supports max effort when using Anthropic-compatible API.
export function modelSupportsMaxEffort(model: string): boolean {
const supported3P = get3PModelCapabilityOverride(model, 'max_effort')
if (supported3P !== undefined) {
return supported3P
}
// Support DeepSeek V4 Pro specifically (Anthropic-compatible API)
if (model.toLowerCase().includes('deepseek-v4-pro')) {
return true
}
if (
model.toLowerCase().includes('opus-4-7') ||
model.toLowerCase().includes('opus-4-6')
Expand Down Expand Up @@ -267,7 +273,7 @@ export function getEffortLevelDescription(level: EffortLevel): string {
case 'xhigh':
return 'Extended reasoning beyond high, short of max (Opus 4.7 only)'
case 'max':
return 'Maximum capability with deepest reasoning (Opus 4.6/4.7 only)'
return 'Maximum capability with deepest reasoning (Opus 4.6/4.7/DeepSeek V4 Pro)'
}
}

Expand Down
Loading