This repository was archived by the owner on May 6, 2020. It is now read-only.
One proxy per vm#167
Merged
Merged
Conversation
added 6 commits
November 13, 2017 15:25
Correct an error message containing a typographical mistake. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
getSocketPath() now accepts a URI (specified by a new "-uri" CLI option) that specifies the socket to use. If the specified socket path is empty, the old behaviour is applied. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com> Contributions-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Add the syslog logrus package. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Write log output to syslog rather than stderr when running as a pod instance. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Don't run KSM code when running a pod-specific instance. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signal the proxy to shutdown when unregisterVM() is called if running as a pod instance. Note that the shutdown cannot be immediate: it must first send back the response frame and wait for the hypervisor to stop. Fixes clearcontainers#164. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
7 tasks
Author
|
Tested locally to ensure it is possible to run a system-level |
|
@jodh-intel oh ok so you mean with this patch, we can still use the proxy as a single instance ? |
Author
|
Hi @sboeuf - yes, we can retain the systemd-spawned instance for the time being, then remove that functionality later. This multi-step process allows us to keep disruption to a minimum. See clearcontainers/runtime#795. |
|
@jodh-intel that's perfect to go step by step, I agree we don't want to break everyhting :) |
|
kubernetes qa-passed 👍 |
|
LGTM |
|
@amshinde please take a look and merge this so that we can move forward with containers/virtcontainers#483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the proxy to be run for a single pod.
This branch allows multiple proxies to be run on a single system, one per pod. Note that it also permits this behaviour even when the proxy is run as a system-level systemd service.