Skip to content

USR-238 fix(clerk-js): Allow to delete username if optional #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raptisj merged 1 commit into from
Aug 11, 2023
Merged

USR-238 fix(clerk-js): Allow to delete username if optional #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/red-deers-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---
Comment thread
raptisj marked this conversation as resolved.

Fix a bug where it was not possible to delete the username if it was optional.
8 changes: 6 additions & 2 deletions packages/clerk-js/src/ui/components/UserProfile/UsernamePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { useWizard, Wizard } from '../../common';
import { useCoreUser } from '../../contexts';
import { useCoreUser, useEnvironment } from '../../contexts';
import { localizationKeys } from '../../customizables';
import { ContentPage, Form, FormButtons, SuccessPage, useCardState, withCardStateProvider } from '../../elements';
import { handleError, useFormControl } from '../../utils';
import { UserProfileBreadcrumbs } from './UserProfileNavbar';

export const UsernamePage = withCardStateProvider(() => {
const user = useCoreUser();
const { userSettings } = useEnvironment();
const card = useCardState();
const wizard = useWizard();
const usernameField = useFormControl('username', user.username || '', {
Expand All @@ -15,7 +16,10 @@ export const UsernamePage = withCardStateProvider(() => {
placeholder: localizationKeys('formFieldInputPlaceholder__username'),
});

const canSubmit = usernameField.value.length > 1 && user.username !== usernameField.value;
const isUsernameRequired = userSettings.attributes.username.required;

const canSubmit =
(isUsernameRequired ? usernameField.value.length > 1 : true) && user.username !== usernameField.value;

const updatePassword = async () => {
try {
Expand Down