Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fresh-papayas-cheat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

`<SignIn/>`, `<SignUp/>`, `<RedirectToSignin/>`, `<RedirectToSignUp/>`, `clerk.redirectToSignIn()` and `clerk.redirectToSignUp()` now accept the `initialValues` option, which will prefill the appropriate form fields with the values provided.
18 changes: 12 additions & 6 deletions packages/clerk-js/src/core/clerk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ import type {
Resources,
SetActiveParams,
SignInProps,
SignInRedirectOptions,
SignInResource,
SignOut,
SignOutCallback,
SignOutOptions,
SignUpField,
SignUpProps,
SignUpRedirectOptions,
SignUpResource,
UnsubscribeCallback,
UserButtonProps,
Expand All @@ -58,6 +60,7 @@ import type { MountComponentRenderer } from '../ui/Components';
import { completeSignUpFlow } from '../ui/components/SignUp/util';
import {
appendAsQueryParams,
appendUrlsAsQueryParams,
buildURL,
createBeforeUnloadTracker,
createCookieHandler,
Expand Down Expand Up @@ -694,11 +697,11 @@ export default class Clerk implements ClerkInterface {
return setDevBrowserJWTInURL(toURL, devBrowserJwt, asQueryParam).href;
}

public buildSignInUrl(options?: RedirectOptions): string {
public buildSignInUrl(options?: SignInRedirectOptions): string {
return this.#buildUrl('signInUrl', options);
}

public buildSignUpUrl(options?: RedirectOptions): string {
public buildSignUpUrl(options?: SignUpRedirectOptions): string {
return this.#buildUrl('signUpUrl', options);
}

Expand Down Expand Up @@ -757,14 +760,14 @@ export default class Clerk implements ClerkInterface {
return;
};

public redirectToSignIn = async (options?: RedirectOptions): Promise<unknown> => {
public redirectToSignIn = async (options?: SignInRedirectOptions): Promise<unknown> => {
if (inBrowser()) {
return this.navigate(this.buildSignInUrl(options));
}
return;
};

public redirectToSignUp = async (options?: RedirectOptions): Promise<unknown> => {
public redirectToSignUp = async (options?: SignUpRedirectOptions): Promise<unknown> => {
if (inBrowser()) {
return this.navigate(this.buildSignUpUrl(options));
}
Expand Down Expand Up @@ -1456,7 +1459,7 @@ export default class Clerk implements ClerkInterface {
});
};

#buildUrl = (key: 'signInUrl' | 'signUpUrl', options?: RedirectOptions): string => {
#buildUrl = (key: 'signInUrl' | 'signUpUrl', options?: SignInRedirectOptions | SignUpRedirectOptions): string => {
if (!this.#isReady || !this.#environment || !this.#environment.displayConfig) {
return '';
}
Expand All @@ -1472,7 +1475,10 @@ export default class Clerk implements ClerkInterface {
{ options: this.#options, displayConfig: this.#environment.displayConfig },
false,
);
return this.buildUrlWithAuth(appendAsQueryParams(signInOrUpUrl, opts));

return this.buildUrlWithAuth(
appendUrlsAsQueryParams(appendAsQueryParams(signInOrUpUrl, options?.initialValues || {}), opts),
Comment thread
desiprisg marked this conversation as resolved.
);
};

assertComponentsReady(controls: unknown): asserts controls is ReturnType<MountComponentRenderer> {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/core/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ export const ERROR_CODES = {
NOT_ALLOWED_ACCESS: 'not_allowed_access',
SAML_USER_ATTRIBUTE_MISSING: 'saml_user_attribute_missing',
};

export const SIGN_IN_INITIAL_VALUE_KEYS = ['email_address', 'phone_number', 'username'];
export const SIGN_UP_INITIAL_VALUE_KEYS = ['email_address', 'phone_number', 'username', 'first_name', 'last_name'];
55 changes: 42 additions & 13 deletions packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ClerkAPIError, SignInCreateParams } from '@clerk/types';
import React, { useEffect, useMemo, useRef, useState } from 'react';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { ERROR_CODES } from '../../../core/constants';
import { clerkInvalidFAPIResponse } from '../../../core/errors';
Expand Down Expand Up @@ -64,42 +64,73 @@ export function _SignInStart(): JSX.Element {
placeholder: localizationKeys('formFieldInputPlaceholder__password') as any,
});

const identifierField = useFormControl('identifier', '', {
const ctxInitialValues = ctx.initialValues || {};
const initialValues: Record<SignInStartIdentifier, string | undefined> = useMemo(
() => ({
email_address: ctxInitialValues.emailAddress,
email_address_username: ctxInitialValues.emailAddress || ctxInitialValues.username,
username: ctxInitialValues.username,
phone_number: ctxInitialValues.phoneNumber,
}),
[ctx.initialValues],
);

const hasSocialOrWeb3Buttons = !!authenticatableSocialStrategies.length || !!web3FirstFactors.length;
const [shouldAutofocus, setShouldAutofocus] = useState(!isMobileDevice() && !hasSocialOrWeb3Buttons);
Comment thread
desiprisg marked this conversation as resolved.
const textIdentifierField = useFormControl('identifier', initialValues[identifierAttribute] || '', {
...currentIdentifier,
isRequired: true,
});

const phoneIdentifierField = useFormControl('identifier', initialValues['phone_number'] || '', {
...currentIdentifier,
isRequired: true,
});

const identifierField = identifierAttribute === 'phone_number' ? phoneIdentifierField : textIdentifierField;

const identifierFieldRef = useRef<HTMLInputElement>(null);

const switchToNextIdentifier = () => {
setIdentifierAttribute(
i => identifierAttributes[(identifierAttributes.indexOf(i) + 1) % identifierAttributes.length],
);
identifierField.setValue('');
setShouldAutofocus(true);
};

const switchToPhoneInput = (value?: string) => {
const switchToPhoneInput = () => {
setIdentifierAttribute('phone_number');
identifierField.setValue(value || '');
setShouldAutofocus(true);
Comment thread
desiprisg marked this conversation as resolved.
};

// switch to the phone input (if available) if a "+" is entered
// (either by the browser or the user)
// this does not work in chrome as it does not fire the change event and the value is
// not available via js
React.useLayoutEffect(() => {
useLayoutEffect(() => {
if (
identifierField.value.startsWith('+') &&
identifierAttributes.includes('phone_number') &&
identifierAttribute !== 'phone_number' &&
!hasSwitchedByAutofill
) {
switchToPhoneInput(identifierField.value);
switchToPhoneInput();
// do not switch automatically on subsequent autofills
// by the browser to avoid a switch loop
setHasSwitchedByAutofill(true);
}
}, [identifierField.value, identifierAttributes]);

React.useEffect(() => {
useLayoutEffect(() => {
if (identifierAttribute === 'phone_number' && identifierField.value) {
//value should be kept as we have auto-switched to the phone input
return;
}

identifierField.setValue(initialValues[identifierAttribute] || '');
}, [identifierAttribute]);

useEffect(() => {
if (!organizationTicket) {
return;
}
Expand Down Expand Up @@ -137,7 +168,7 @@ export function _SignInStart(): JSX.Element {
});
}, []);

React.useEffect(() => {
useEffect(() => {
async function handleOauthError() {
const error = signIn?.firstFactorVerification?.error;
if (error) {
Expand Down Expand Up @@ -244,9 +275,6 @@ export function _SignInStart(): JSX.Element {
return <LoadingCard />;
}

const hasSocialOrWeb3Buttons = !!authenticatableSocialStrategies.length || !!web3FirstFactors.length;
const shouldAutofocus = !isMobileDevice() && !hasSocialOrWeb3Buttons;

return (
<Flow.Part part='start'>
<Card>
Expand All @@ -271,6 +299,7 @@ export function _SignInStart(): JSX.Element {
<Form.Root onSubmit={handleFirstPartySubmit}>
<Form.ControlRow elementId={identifierField.id}>
<Form.Control
ref={identifierFieldRef}
actionLabel={nextIdentifier?.action}
onActionClicked={switchToNextIdentifier}
{...identifierField.props}
Expand Down Expand Up @@ -303,7 +332,7 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
const ref = useRef<HTMLInputElement>(null);

// show password if it's autofilled by the browser
React.useLayoutEffect(() => {
useLayoutEffect(() => {
const intervalId = setInterval(() => {
if (ref?.current) {
const autofilled = window.getComputedStyle(ref.current, ':autofill').animationName === 'onAutoFillStart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,4 +222,36 @@ describe('SignInStart', () => {
expect(screen.getByRole('textbox', { name: /phone number/i })).toHaveAttribute('type', 'tel');
});
});

describe('initialValues', () => {
it('prefills the emailAddress field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withEmailAddress();
});
props.setProps({ initialValues: { emailAddress: 'foo@clerk.com' } });

render(<SignInStart />, { wrapper });
screen.getByDisplayValue(/foo@clerk.com/i);
});

it('prefills the phoneNumber field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withPhoneNumber();
});
props.setProps({ initialValues: { phoneNumber: '+306911111111' } });

render(<SignInStart />, { wrapper });
screen.getByDisplayValue(/691 1111111/i);
});

it('prefills the username field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withUsername();
});

props.setProps({ initialValues: { username: 'foo' } });
render(<SignInStart />, { wrapper });
screen.getByDisplayValue(/foo/i);
});
});
});
12 changes: 6 additions & 6 deletions packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function _SignUpContinue() {
const { navigate } = useRouter();
const { displayConfig, userSettings } = useEnvironment();
const { attributes } = userSettings;
const { navigateAfterSignUp, signInUrl, unsafeMetadata } = useSignUpContext();
const { navigateAfterSignUp, signInUrl, unsafeMetadata, initialValues = {} } = useSignUpContext();
const signUp = useCoreSignUp();
const isProgressiveSignUp = userSettings.signUp.progressive;
const [activeCommIdentifierType, setActiveCommIdentifierType] = React.useState<ActiveIdentifier>(
Expand All @@ -47,27 +47,27 @@ function _SignUpContinue() {

// TODO: This form should be shared between SignUpStart and SignUpContinue
const formState = {
firstName: useFormControl('firstName', '', {
firstName: useFormControl('firstName', initialValues.firstName || '', {
type: 'text',
label: localizationKeys('formFieldLabel__firstName'),
placeholder: localizationKeys('formFieldInputPlaceholder__firstName'),
}),
lastName: useFormControl('lastName', '', {
lastName: useFormControl('lastName', initialValues.lastName || '', {
type: 'text',
label: localizationKeys('formFieldLabel__lastName'),
placeholder: localizationKeys('formFieldInputPlaceholder__lastName'),
}),
emailAddress: useFormControl('emailAddress', '', {
emailAddress: useFormControl('emailAddress', initialValues.emailAddress || '', {
type: 'email',
label: localizationKeys('formFieldLabel__emailAddress'),
placeholder: localizationKeys('formFieldInputPlaceholder__emailAddress'),
}),
username: useFormControl('username', '', {
username: useFormControl('username', initialValues.username || '', {
type: 'text',
label: localizationKeys('formFieldLabel__username'),
placeholder: localizationKeys('formFieldInputPlaceholder__username'),
}),
phoneNumber: useFormControl('phoneNumber', '', {
phoneNumber: useFormControl('phoneNumber', initialValues.phoneNumber || '', {
type: 'tel',
label: localizationKeys('formFieldLabel__phoneNumber'),
placeholder: localizationKeys('formFieldInputPlaceholder__phoneNumber'),
Expand Down
11 changes: 6 additions & 5 deletions packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ function _SignUpStart(): JSX.Element {
getInitialActiveIdentifier(attributes, userSettings.signUp.progressive),
);
const { t, locale } = useLocalizations();
const initialValues = ctx.initialValues || {};
Comment thread
desiprisg marked this conversation as resolved.

const [missingRequirementsWithTicket, setMissingRequirementsWithTicket] = React.useState(false);

Expand All @@ -51,27 +52,27 @@ function _SignUpStart(): JSX.Element {
const { failedValidationsText } = usePasswordComplexity(passwordSettings);

const formState = {
firstName: useFormControl('firstName', signUp.firstName || '', {
firstName: useFormControl('firstName', signUp.firstName || initialValues.firstName || '', {
type: 'text',
label: localizationKeys('formFieldLabel__firstName'),
placeholder: localizationKeys('formFieldInputPlaceholder__firstName'),
}),
lastName: useFormControl('lastName', signUp.lastName || '', {
lastName: useFormControl('lastName', signUp.lastName || initialValues.lastName || '', {
type: 'text',
label: localizationKeys('formFieldLabel__lastName'),
placeholder: localizationKeys('formFieldInputPlaceholder__lastName'),
}),
emailAddress: useFormControl('emailAddress', signUp.emailAddress || '', {
emailAddress: useFormControl('emailAddress', signUp.emailAddress || initialValues.emailAddress || '', {
type: 'email',
label: localizationKeys('formFieldLabel__emailAddress'),
placeholder: localizationKeys('formFieldInputPlaceholder__emailAddress'),
}),
username: useFormControl('username', signUp.username || '', {
username: useFormControl('username', signUp.username || initialValues.username || '', {
type: 'text',
label: localizationKeys('formFieldLabel__username'),
placeholder: localizationKeys('formFieldInputPlaceholder__username'),
}),
phoneNumber: useFormControl('phoneNumber', signUp.phoneNumber || '', {
phoneNumber: useFormControl('phoneNumber', signUp.phoneNumber || initialValues.phoneNumber || '', {
type: 'tel',
label: localizationKeys('formFieldLabel__phoneNumber'),
placeholder: localizationKeys('formFieldInputPlaceholder__phoneNumber'),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,36 @@ describe('SignUpStart', () => {
expect(screen.getByRole('textbox', { name: 'Phone number' })).toHaveValue('(123) 456-789');
});
});

describe('initialValues', () => {
it('prefills the emailAddress field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withEmailAddress();
});
props.setProps({ initialValues: { emailAddress: 'foo@clerk.com' } });

render(<SignUpStart />, { wrapper });
screen.getByDisplayValue(/foo@clerk.com/i);
});

it('prefills the phoneNumber field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withPhoneNumber();
});
props.setProps({ initialValues: { phoneNumber: '+306911111111' } });

render(<SignUpStart />, { wrapper });
screen.getByDisplayValue(/691 1111111/i);
});

it('prefills the username field with the correct initial value', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withUsername();
});

props.setProps({ initialValues: { username: 'foo' } });
render(<SignUpStart />, { wrapper });
screen.getByDisplayValue(/foo/i);
});
});
});
Loading