Skip to content

fix(clerk-js): Added padding for ArrowBlockButton to prevent layout shift #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
octoper merged 4 commits into from
Sep 28, 2023
Merged

fix(clerk-js): Added padding for ArrowBlockButton to prevent layout shift #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d94638
fix(clerk-js): Added padding for ArrowBlockButton to prevent layout s…
octoper Sep 14, 2023
aa2f02e
chore(repo): Adds changeset
octoper Sep 14, 2023
f16e3cf
Update .changeset/large-baboons-hope.md
octoper Sep 15, 2023
3e1f0e1
fix(clerk-js): Added padding to the Spinner component
octoper Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-baboons-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Updated the OAuth buttons in the SignIn and SignUp components to prevent layout shifts while loading.
8 changes: 6 additions & 2 deletions packages/clerk-js/src/ui/elements/ArrowBlockButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ export const ArrowBlockButton = (props: ArrowBlockButtonProps) => {
<Spinner
elementDescriptor={spinnerElementDescriptor}
elementId={spinnerElementId}
sx={{ position: 'absolute' }}
size={'sm'}
size={'md'}
Comment thread
octoper marked this conversation as resolved.
sx={theme => [
{
padding: theme.space.$2,
},
]}
/>
) : !isIconElement && leftIcon ? (
<Icon
Expand Down