chore(nextjs): Apply deprecation warnings - #1760
Conversation
🦋 Changeset detectedLatest commit: 4293442 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b9a21ca to
8109799
Compare
| @@ -0,0 +1,63 @@ | |||
| // copy of packages/shared/src/utils/deprecated.ts | |||
There was a problem hiding this comment.
We need to spend time on fixing this error and the copy/paste should only be the very last resort.
What happens if you put "use client" into the usePagesOrInfinite file?
And if that doesn't help (and the file is not actually used) we need to think about splitting the utils into their own nested exports so that the bundler can tree-shake the rest
There was a problem hiding this comment.
I wanted to avoid introducing changes in @clerk/shared that would require extensive testing in this PR so I followed the naive approach of copy / paste to proceed with this PR objective and introduce another PR to support importing @clerk/shared in server-side frameworks.
Based on your comment, if we consider blocking this PR until the @clerk/shared is fixed and used I have opened the following PR in which we should also check if the @clerk/shared is tree-shakeable or not before we merge it: #1767
cc: @SokratisVidros
8109799 to
94cc434
Compare
94cc434 to
2b270f1
Compare
91930e0 to
333ea4d
Compare
b9df973 to
39a24a0
Compare
333ea4d to
1f7dbe0
Compare
39a24a0 to
5864bc7
Compare
…variable deprecation
1f7dbe0 to
4293442
Compare
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
** REVIEW IT PER COMMIT **
Warn about deprecations of the following in Clerk Nextjs:
withClerkMiddlewarewithServerSideAuthCLERK_JS_VERSIONenvironment variableCLERK_API_KEYenvironment variableNEXT_PUBLIC_FRONTEND_APIenvironment variableChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore