Skip to content

fix(clerk-js): Correctly set idle card state on add mfa error #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desiprisg merged 1 commit into from
Oct 9, 2023
Merged

fix(clerk-js): Correctly set idle card state on add mfa error #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-dolls-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Correctly set idle card state when an error occurs during the MFA set up phase.
19 changes: 10 additions & 9 deletions packages/clerk-js/src/ui/components/UserProfile/MfaPhoneCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,22 @@ const AddMfa = (props: AddMfaProps) => {
const user = useCoreUser();
const availableMethods = user.phoneNumbers.filter(p => !p.reservedForSecondFactor);

const enableMfa = (phone: PhoneNumberResource) => {
const enableMfa = async (phone: PhoneNumberResource) => {
if (phone.verification.status !== 'verified') {
return onUnverifiedPhoneClick(phone);
}

card.setLoading(phone.id);
phone
.setReservedForSecondFactor({ reserved: true })
.then(() => {
card.setIdle();
try {
await phone.setReservedForSecondFactor({ reserved: true }).then(() => {
resourceRef.current = phone;
onSuccess();
})
.catch(err => handleError(err, [], card.setError));

resourceRef.current = phone;
});
} catch (err) {
handleError(err, [], card.setError);
} finally {
card.setIdle();
}
};

return (
Expand Down