feat(clerk-js,backend): Throw error if signInUrl is on same origin as a satellite app - #1845
Merged
nikosdouvlis merged 1 commit intoOct 10, 2023
Conversation
🦋 Changeset detectedLatest commit: cb9fc2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
force-pushed
the
george/usr-240-throw-error-if-app-is-in-a-satellite-domain-but-signinurl-is
branch
from
October 7, 2023 15:07
5b31c81 to
f74dd00
Compare
panteliselef
reviewed
Oct 8, 2023
desiprisg
force-pushed
the
george/usr-240-throw-error-if-app-is-in-a-satellite-domain-but-signinurl-is
branch
from
October 9, 2023 12:42
f74dd00 to
2e2864f
Compare
panteliselef
reviewed
Oct 9, 2023
desiprisg
force-pushed
the
george/usr-240-throw-error-if-app-is-in-a-satellite-domain-but-signinurl-is
branch
from
October 9, 2023 13:58
2e2864f to
5822cae
Compare
dimkl
approved these changes
Oct 9, 2023
| if (signInUrl.origin === window.location.origin) { | ||
| clerkInvalidSignInUrlOrigin(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
🙃
#validateMultiDomainOptions = () => {
// ...
if (this.#options.signInUrl) {
this.#assertSignInUrlFormatAndOrigin(this.#options.signInUrl, window.location.origin);
}
// ...
}
#assertSignInUrlFormatAndOrigin = (signInUrl: string, origin: string): never => {
try {
signInUrl = new URL(signInUrl);
} catch {
clerkInvalidSignInUrlFormat();
}
if (signInUrl.origin === window.location.origin) {
clerkInvalidSignInUrlOrigin();
}
}
desiprisg
force-pushed
the
george/usr-240-throw-error-if-app-is-in-a-satellite-domain-but-signinurl-is
branch
from
October 9, 2023 15:49
5822cae to
cb9fc2d
Compare
panteliselef
approved these changes
Oct 10, 2023
nikosdouvlis
added this pull request to the merge queue
Oct 10, 2023
nikosdouvlis
deleted the
george/usr-240-throw-error-if-app-is-in-a-satellite-domain-but-signinurl-is
branch
October 10, 2023 09:29
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore