Skip to content

fix(clerk-js): Disable country code picker when form is submitting - #1853

Merged
desiprisg merged 1 commit into
mainfrom
disable_country_picker
Oct 10, 2023
Merged

fix(clerk-js): Disable country code picker when form is submitting#1853
desiprisg merged 1 commit into
mainfrom
disable_country_picker

Conversation

@desiprisg

Copy link
Copy Markdown
Contributor

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@desiprisg
desiprisg requested a review from a team as a code owner October 10, 2023 12:21
@changeset-bot

changeset-bot Bot commented Oct 10, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0a9c25a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/clerk-js/src/ui/elements/PhoneInput/PhoneInput.tsx Outdated
@desiprisg
desiprisg force-pushed the disable_country_picker branch from 6107dbd to 0a9c25a Compare October 10, 2023 12:53

@anagstef anagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@desiprisg
desiprisg added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit f6faf6f Oct 10, 2023
@desiprisg
desiprisg deleted the disable_country_picker branch October 10, 2023 13:12
@clerk-cookie clerk-cookie mentioned this pull request Oct 10, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants