-
Notifications
You must be signed in to change notification settings - Fork 460
chore(shared,clerk-expo): Apply deprecation warnings env variables #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
260b2aa
chore(gatsby-plugin-clerk): Warn about CLERK_API_KEY environment vari…
dimkl b032927
chore(remix): Warn about CLERK_API_KEY environment variable deprecation
dimkl 376a588
chore(clerk-sdk-node): Warn about CLERK_API_KEY environment variable …
dimkl 40d3d98
chore(clerk-sdk-node): Warn about CLERK_FRONTEND_API environment vari…
dimkl e801bce
chore(gatsby-plugin-clerk): Warn about CLERK_FRONTEND_API environment…
dimkl de0ff53
fixup! chore(remix): Warn about CLERK_API_KEY environment variable de…
dimkl 82fb86e
chore(remix): Warn about CLERK_FRONTEND_API environment variable depr…
dimkl 38f57b8
chore(nextjs): Fix process env type of CLERK_SECRET_KEY
dimkl 7358072
chore(nextjs): Warn about `NEXT_PUBLIC_CLERK_FRONTEND_API` deprecatio…
dimkl 1fbb8c6
chore(clerk-expo): Warn about `CLERK_FRONTEND_API` deprecation warning
dimkl 1def5d5
chore(repo): Add changeset
dimkl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| 'gatsby-plugin-clerk': patch | ||
| '@clerk/clerk-sdk-node': patch | ||
| '@clerk/nextjs': patch | ||
| '@clerk/remix': patch | ||
| '@clerk/clerk-expo': patch | ||
| --- | ||
|
|
||
| Warn about environment variables deprecations: | ||
|
|
||
| - `CLERK_API_KEY` | ||
| - `CLERK_FRONTEND_API` | ||
| - `NEXT_PUBLIC_CLERK_FRONTEND_API` | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { deprecated } from '@clerk/shared'; | ||
|
|
||
| export const API_URL = process.env.CLERK_API_URL || 'https://api.clerk.dev'; | ||
| export const API_VERSION = process.env.CLERK_API_VERSION || 'v1'; | ||
| /** | ||
| * @deprecated Use `CLERK_SECRET_KEY` instead. | ||
| */ | ||
| export const API_KEY = process.env.CLERK_API_KEY || ''; | ||
| if (API_KEY) { | ||
| deprecated('CLERK_API_KEY', 'Use `CLERK_SECRET_KEY` environment variable instead.'); | ||
| } | ||
| export const SECRET_KEY = process.env.CLERK_SECRET_KEY || ''; | ||
| /** | ||
| * @deprecated Use `PUBLISHABLE_KEY` instead. | ||
| */ | ||
| export const FRONTEND_API = process.env.GATSBY_CLERK_FRONTEND_API || ''; | ||
| if (FRONTEND_API) { | ||
| deprecated('FRONTEND_API', 'Use `PUBLISHABLE_KEY` environment variable instead.'); | ||
| } | ||
| export const PUBLISHABLE_KEY = process.env.GATSBY_CLERK_PUBLISHABLE_KEY || ''; | ||
|
|
||
| export const CLERK_JS = process.env.GATSBY_CLERK_JS; | ||
| export const PROXY_URL = process.env.GATSBY_CLERK_PROXY_URL; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 2 additions & 9 deletions
11
packages/gatsby-plugin-clerk/src/ssr/authenticateRequest.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| export * from './withServerAuth'; | ||
| export * from './clerkClient'; | ||
| // TODO(@dimkl): Exposing env variables should be dropped in favor of a | ||
| // universal config loaded. Export `constants` will be dropped in later version. | ||
| export * from '../constants'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.