feat(clerk-js): Autoswitch to phone input if the only sign in initial value is the phone number - #1861
Merged
desiprisg merged 1 commit intoOct 12, 2023
Conversation
🦋 Changeset detectedLatest commit: 94daab2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Oct 11, 2023
| const onlyPhoneNumberInitialValueExists = | ||
| !!ctx.initialValues?.phoneNumber && !(ctx.initialValues.emailAddress || ctx.initialValues.username); | ||
| const shouldStartWithPhoneNumberIdentifier = | ||
| !!onlyPhoneNumberInitialValueExists && identifierAttributes.includes('phone_number'); |
Contributor
There was a problem hiding this comment.
Suggested change
| !!onlyPhoneNumberInitialValueExists && identifierAttributes.includes('phone_number'); | |
| onlyPhoneNumberInitialValueExists && identifierAttributes.includes('phone_number'); |
desiprisg
force-pushed
the
george/usr-405-autoswitch-to-phone-number-input-on-sign-in-start-if-just
branch
from
October 12, 2023 01:46
ceb59ac to
636b9cc
Compare
…lue is the phone number
desiprisg
force-pushed
the
george/usr-405-autoswitch-to-phone-number-input-on-sign-in-start-if-just
branch
from
October 12, 2023 01:56
29bed70 to
94daab2
Compare
desiprisg
enabled auto-merge
October 12, 2023 01:56
desiprisg
added this pull request to the merge queue
Oct 12, 2023
desiprisg
deleted the
george/usr-405-autoswitch-to-phone-number-input-on-sign-in-start-if-just
branch
October 12, 2023 02:12
Merged
dimkl
reviewed
Oct 12, 2023
| onlyPhoneNumberInitialValueExists && identifierAttributes.includes('phone_number'); | ||
| const [identifierAttribute, setIdentifierAttribute] = useState<SignInStartIdentifier>( | ||
| shouldStartWithPhoneNumberIdentifier ? 'phone_number' : identifierAttributes[0] || '', | ||
| ); |
Contributor
There was a problem hiding this comment.
🙃 instead of using phone_number hard coded string, could we use PhoneNumberIdentifier from @clerk/types?
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start with the phone input if the only sign in initial value is the phone number.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore