Skip to content

fix(clerk-js): Correctly navigate to the continue route if needed during verification #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desiprisg merged 1 commit into from
Oct 16, 2023
Merged

fix(clerk-js): Correctly navigate to the continue route if needed during verification #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-points-applaud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Add new `/sign-up/continue/verify-phone-number` and `/sign-up/continue/verify-email-address` routes in order to allow navigating back to the `/sign-up/continue` step when editing the extra identifier that is provided in the `/sign-up/continue` step.
16 changes: 15 additions & 1 deletion packages/clerk-js/src/ui/components/SignUp/SignUp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,21 @@ function SignUpRoutes(): JSX.Element {
/>
</Route>
<Route path='continue'>
<SignUpContinue />
<Route
path='verify-email-address'
canActivate={clerk => !!clerk.client.signUp.emailAddress}
>
<SignUpVerifyEmail />
</Route>
<Route
path='verify-phone-number'
canActivate={clerk => !!clerk.client.signUp.phoneNumber}
>
<SignUpVerifyPhone />
</Route>
<Route index>
<SignUpContinue />
</Route>
</Route>
<Route index>
<SignUpStart />
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ function _SignUpContinue() {
.then(res =>
completeSignUpFlow({
signUp: res,
verifyEmailPath: '../verify-email-address',
verifyPhonePath: '../verify-phone-number',
verifyEmailPath: './verify-email-address',
verifyPhonePath: './verify-phone-number',
handleComplete: () => clerk.setActive({ session: res.createdSessionId, beforeEmit: navigateAfterSignUp }),
navigate,
}),
Expand Down