chore(clerk-react,shared): Temp fix for ESLint errors - #1887
Closed
tmilewski wants to merge 3 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: a4213bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
force-pushed
the
build/turbo-task-inputs-fix-linting-issues
branch
from
October 15, 2023 21:20
0833817 to
a4213bf
Compare
Member
|
@tmilewski are these throwing locally or only on CICD? |
Member
Author
|
@nikosdouvlis They started showing up here: #1882 and only on CI. There are a few things weird here, one of which being that I "fix" the one CI errors out on and another one in a different package pops up. It's whack-a-mole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting
mainintentionally so that actions will run. Parent is #1882, and will adjust.Description
Fixes (temp) some ESLint issues which popped up per the parent PR. Unsure how they only popped up now, as it has nothing to with the parent PR's work.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore