Skip to content

chore(clerk-js): Keep CreateOrganizationForm disabled if avatar has been uploaded and org name is empty #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikospapcom merged 1 commit into from
Oct 18, 2023
Merged

chore(clerk-js): Keep CreateOrganizationForm disabled if avatar has been uploaded and org name is empty #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-shoes-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Keep `CreateOrganizationForm` disabled in case of an uploaded avatar and organization name is empty.
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/components/CreateOrganization/CreateOrganizationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const CreateOrganizationForm = (props: CreateOrganizationFormProps) => {
});

const dataChanged = !!nameField.value;
const canSubmit = dataChanged || !!file;
const canSubmit = dataChanged;

@desiprisg desiprisg Oct 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the avatar get uploaded without submitting the form? Is that why we don't check for it here?

@desiprisg desiprisg Oct 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is there not form.isDirty or something similar in clerk-js?

@panteliselef panteliselef Oct 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upload the logo, after the org is created (after the submission)

No i don't think we support isDirty out of the box.


const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
Expand Down