fix(clerk-js): Fallback to FAPI error message for password pwned case - #2273
Merged
Conversation
🦋 Changeset detectedLatest commit: 5b31b9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
panteliselef
approved these changes
Dec 6, 2023
dimkl
approved these changes
Dec 6, 2023
Contributor
|
@desiprisg we need to backport it to |
desiprisg
force-pushed
the
pwned_error_fallback
branch
from
December 6, 2023 09:53
913e3c6 to
cd3b7f6
Compare
dimkl
reviewed
Dec 6, 2023
24 tasks
desiprisg
force-pushed
the
pwned_error_fallback
branch
2 times, most recently
from
December 6, 2023 10:04
95efb52 to
6589688
Compare
Contributor
|
@desiprisg also don't forget to make the changes for retheme! |
dimkl
reviewed
Dec 6, 2023
Contributor
There was a problem hiding this comment.
🔧 could you remove this file?
desiprisg
added this pull request to the merge queue
Dec 6, 2023
dimkl
removed this pull request from the merge queue due to a manual request
Dec 6, 2023
desiprisg
force-pushed
the
pwned_error_fallback
branch
from
December 6, 2023 12:28
6589688 to
5b31b9b
Compare
desiprisg
enabled auto-merge
December 6, 2023 12:28
desiprisg
added this pull request to the merge queue
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fallback to fapi error when the password has been found in a data breach. This is a very small fix for support, will follow up with a ticket to fix the larger issue with this utility.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore