chore(clerk-js): Remove fallback data for paginated endpoint methods - #2491
Merged
Conversation
We want to allow developers to be able to catch the error themselves
🦋 Changeset detectedLatest commit: ccf6411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
reviewed
Jan 8, 2024
| }; | ||
| }); | ||
| }).then(res => { | ||
| // TODO: Fix typing |
Contributor
There was a problem hiding this comment.
❓ is this different from the above as unknown as ClerkPaginatedResponse... ? I think we should remove this TODO or add also to the other refs of this PR.
Let's also add a ticket to make this refactoring part of the v6 project
Contributor
Author
There was a problem hiding this comment.
I believe we already have one. It is a general issue with BaseResource._fetch and type inference.
dimkl
approved these changes
Jan 8, 2024
panteliselef
added this pull request to the merge queue
Jan 9, 2024
dimkl
added a commit
to clerk/clerk-docs
that referenced
this pull request
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove fallback data and allow promise to throw for paginated endpoint methods.
Affected methods:
The react hooks will continue to fallback to
total_count:0anddata = []in case of an error, but theisErrorproperty will be correctly populated astrueChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore