fix(backend): Fix minor misalignment's with the User FAPI and BAPI classes - #2493
Merged
Conversation
🦋 Changeset detectedLatest commit: ec8179b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
reviewed
Jan 8, 2024
dimkl
left a comment
dimkl
left a comment
Contributor
There was a problem hiding this comment.
I would suggest we use getters for primaryEmailAddress / primaryPhoneNumber , .... instead of adding them as params. I would also suggest a getter for fullName.
Why did we export the getFullName function? I don't see any import or usage outside the User.ts.
dimkl
approved these changes
Jan 10, 2024
Contributor
|
@panteliselef let's create a ticket to introduce a common interface in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User FAPI and User BAPI cannot be fully aligned, but we should aim for keeping their signature as similar as possible.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore