feat(express): Introduce Clerk package for Express - #2918
Merged
Conversation
🦋 Changeset detectedLatest commit: 55d9b64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
suggested changes
Mar 4, 2024
LekoArts
left a comment
LekoArts
left a comment
Contributor
There was a problem hiding this comment.
First pass at looking through the changes :)
dimkl
force-pushed
the
feat/express
branch
2 times, most recently
from
March 11, 2024 18:47
e213120 to
3ed2a03
Compare
dimkl
force-pushed
the
feat/express
branch
3 times, most recently
from
March 15, 2024 13:46
d771634 to
94530c5
Compare
dimkl
force-pushed
the
feat/express
branch
3 times, most recently
from
March 15, 2024 14:00
61e0396 to
2029c38
Compare
dimkl
force-pushed
the
feat/express
branch
2 times, most recently
from
March 29, 2024 11:55
3d62ee1 to
5ac94e9
Compare
Contributor
Author
|
@LekoArts, @nikosdouvlis Could you take another look at this PR? |
dimkl
force-pushed
the
feat/express
branch
3 times, most recently
from
April 2, 2024 20:48
e13a230 to
4a035c5
Compare
LekoArts
approved these changes
Apr 3, 2024
LekoArts
left a comment
LekoArts
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, some minor comments I'd like to resolve before merging
dimkl
force-pushed
the
feat/express
branch
2 times, most recently
from
April 4, 2024 10:34
30cceb7 to
91e596a
Compare
nikosdouvlis
reviewed
Apr 4, 2024
nikosdouvlis
approved these changes
Apr 4, 2024
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
… instead of implicit creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce Express specific Clerk SDK
@clerk/express. The SDK exposes the following API:clerkClient: default @clerk/backend client initialized from env variables and used to make BAPI requestsclerkMiddleware: centralized middleware that authenticates all requests without blocking them (also triggers handshake mechanism)getAuth: utility to retrieve the auth state from the request (requires clerkMiddleware to executed)requireAuth: middleware that returns http 401 response when request is signed-outAlso all the top level exports from
@clerk/backendare re-exported from@clerk/expresstop level.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
TODOs
TODO(express)TODOs