Skip to content

chore(repo): Configure Dependabot - #3051

Closed
tmilewski wants to merge 2 commits into
mainfrom
tom/configure-dependabot
Closed

chore(repo): Configure Dependabot#3051
tmilewski wants to merge 2 commits into
mainfrom
tom/configure-dependabot

Conversation

@tmilewski

@tmilewski tmilewski commented Mar 26, 2024

Copy link
Copy Markdown
Member

Description

Configures Dependabot. See code comments for applied settings.

SDK-1557

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski
tmilewski requested a review from a team March 26, 2024 16:53
@tmilewski tmilewski self-assigned this Mar 26, 2024
@changeset-bot

changeset-bot Bot commented Mar 26, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4be75e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
tmilewski requested a review from jescalan March 26, 2024 16:53
Comment thread .github/dependabot.yml Outdated
update-types:
- "major"
- "minor"
- "patch"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we only wanna apply security patches to core 1, yeah?

Comment thread .github/dependabot.yml
# This configuration will:
# - Check for updates weekly on Wednesday at 12:00 UTC
# - Create one pull request at a time
# - Commit changes with the prefix `chore(repo)` and include the scope

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this one - why is it run on a different day and whats the difference from the other ones?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To offset any required changes, but can standardize. This will be way less frequent than the other two.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure I understand what this means

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is the package-ecosystem key. So the first one will update the package.json entries, the second one will update the GitHub actions.

@tmilewski
tmilewski requested a review from jescalan March 26, 2024 20:31
@LekoArts LekoArts changed the title chore(repo): Configure Dependabot [SDK-1557] chore(repo): Configure Dependabot Mar 27, 2024

@LekoArts LekoArts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See convo in Slack, I'm not sure if Dependabot is the right tool for our use cases

@nikosdouvlis

Copy link
Copy Markdown
Member

Closing this one as it seems we'll be using renovate :) feel free to reopen if this is not the case!

@tmilewski

Copy link
Copy Markdown
Member Author

@nikosdouvlis 👍

@tmilewski
tmilewski deleted the tom/configure-dependabot branch April 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants