Skip to content

Support older ios 13.3 and 13.4 devices - #3101

Merged
nikosdouvlis merged 1 commit into
release/v4from
nikos/attempt-to-support-mobile-ios13
Apr 3, 2024
Merged

Support older ios 13.3 and 13.4 devices#3101
nikosdouvlis merged 1 commit into
release/v4from
nikos/attempt-to-support-mobile-ios13

Conversation

@nikosdouvlis

Copy link
Copy Markdown
Member

Description

This PR attempts to fix compatibility issues for ios 13.3 and ios 13.4 devices (this mainly refers to iPhones and iPads). Changes:

  • Bump TS target to es2020 as this supported by ios 13.3 and 13.4
  • Force safari10 terser mangle option while preserving the default webpack config
  • When using the media.matches API, fallback to the deprecated addListener if found
  • Replace the flex gap property with margin-top and use of "lobotomized owl selector" pattern
  • Updates the webpack and terser dependencies

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Apr 3, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb9e962

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis
nikosdouvlis changed the base branch from main to release/v4 April 3, 2024 09:35
@nikosdouvlis
nikosdouvlis requested a review from a team as a code owner April 3, 2024 09:35
@nikosdouvlis
nikosdouvlis force-pushed the nikos/attempt-to-support-mobile-ios13 branch from 8bdd352 to 9247a5b Compare April 3, 2024 09:39
Comment thread packages/clerk-js/src/ui/elements/FormControl.tsx
Comment thread packages/clerk-js/src/ui/hooks/usePrefersReducedMotion.ts Outdated
Comment thread packages/clerk-js/tsconfig.json
Comment thread packages/clerk-js/src/ui/primitives/gapPropertyCompat.ts
@nikosdouvlis
nikosdouvlis force-pushed the nikos/attempt-to-support-mobile-ios13 branch from 9247a5b to 50be02f Compare April 3, 2024 09:52
Comment thread packages/clerk-js/src/ui/hooks/usePrefersReducedMotion.ts
@nikosdouvlis
nikosdouvlis force-pushed the nikos/attempt-to-support-mobile-ios13 branch from 50be02f to eb9e962 Compare April 3, 2024 10:09
@nikosdouvlis
nikosdouvlis merged commit ac0005b into release/v4 Apr 3, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/attempt-to-support-mobile-ios13 branch April 3, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants