Skip to content

fix(clerk-js): Use first-party cookies when running on Cypress #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brkalow merged 5 commits into from
May 9, 2024
Merged

fix(clerk-js): Use first-party cookies when running on Cypress #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c338358
fix(clerk-js): Use first-party cookies when running on Cypress
Apr 23, 2024
bd3f75e
fix(clerk-js): Create isCypress util
Apr 24, 2024
05dec70
Merge branch 'main' into stefanos/fix-cookies-on-cypress
anagstef May 8, 2024
47a3ff9
Merge branch 'main' into stefanos/fix-cookies-on-cypress
anagstef May 9, 2024
fc3a263
Merge branch 'main' into stefanos/fix-cookies-on-cypress
brkalow May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-rats-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix Cypress setting cookies as third-party
8 changes: 7 additions & 1 deletion packages/clerk-js/src/utils/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ export function usesHttps() {
return inBrowser() && window.location.protocol === 'https:';
}

function isCypress() {
return typeof window !== 'undefined' && typeof (window as any).Cypress !== 'undefined';
}

export function inIframe() {
return inBrowser() && window.self !== window.top;
// checks if the current window is an iframe
// excludes the case where the current window runs in a Cypress test
return inBrowser() && window.self !== window.top && !isCypress();
}

export function inCrossOriginIframe() {
Expand Down