fix(clerk-expo): Use atob polyfill when using Hermes JS engine - #3354
Conversation
🦋 Changeset detectedLatest commit: 7e206ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Can we detect the expo version used and polyfil for >51? |
2bd767b to
8da6f50
Compare
|
Opted in checking for hermes and only applying the polyfill in that case. https://reactnative.dev/docs/hermes#confirming-hermes-is-in-use |
|
Just adding a comment to say that I got this error when using This PR seems to have solved my issue. Thanks! |
8da6f50 to
7e206ff
Compare
|
!snapshot |
|
Hey @desiprisg - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/clerk-expo@1.0.8-snapshot.v7e206ff --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact |
Description
Use a polyfill for the
atobfunction to prevent errors when using the Hermes JS engine, since the engine's implementation is stricter than it should be and errors when the publishable key's base64 encoded part's length is not divisible by 4.Related issue by the default JS engine for expo 51: facebook/hermes#1379
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change