fix(elements): Fix follow-on initialization discrepancies - #3377
Merged
tmilewski merged 4 commits intoMay 13, 2024
Conversation
🦋 Changeset detectedLatest commit: 3d4491b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
commented
May 13, 2024
tmilewski
commented
May 13, 2024
LekoArts
added a commit
that referenced
this pull request
May 14, 2024
* chore(elements): Add changeset * Apply suggestions from code review Co-authored-by: Bryce Kalow <bryce@clerk.dev> * feat(elements): Add `complete` step to Sign Up and Sign In. [SDK-1712] * chore(elements): Remove comment * chore(elements): Remove complete step * chore(elements): Update sign-in Step docs * fix(elements): Fix follow-on initialization discrepancies (#3377) * fix(elements): Follow-on machine initialization [SDK-1746] * chore(elements): Add changeset * chore(elements): Remove unnecessary TS comment * chore(elements): Add line item to changeset * chore(repo): Update changeset --------- Co-authored-by: Bryce Kalow <bryce@clerk.dev> Co-authored-by: LekoArts <lekoarts@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an addendum to the sign in/sign up updates seen in #3343.
This PR does the following:
.setActive. The machine retains the current state throughout thesetActiveflow and resets after that's done.STRATEGY.UNREGISTERevent from being called on stopped machines.Fixes SDK-1746
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change