-
Notifications
You must be signed in to change notification settings - Fork 460
feat(clerk-js,clerk-react,nextjs,types): Drop experimental tag from GoogleOneTap #3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d1fc0b8
feat(clerk-js,clerk-react,nextjs,types): Drop experimental tag from G…
panteliselef 33449e7
feat(clerk-js,clerk-react,nextjs,types): Add changeset
panteliselef 1f5b903
test(chrome-extension): Update snapshots
panteliselef e97824f
Merge branch 'main' into elef/prepare-one-tap-for-ga
panteliselef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/nextjs': minor | ||
| '@clerk/clerk-react': minor | ||
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| Add support for GoogleOneTap. New APIs listed: | ||
| ### React component | ||
| - `<GoogleOneTap/>` | ||
|
|
||
| Customize the UX of the prompt | ||
|
|
||
| ```tsx | ||
| <GoogleOneTap | ||
| cancelOnTapOutside={false} | ||
| itpSupport={false} | ||
| fedCmSupport={false} | ||
| /> | ||
| ``` | ||
|
|
||
| ### Use the component from with Vanilla JS | ||
| - `Clerk.openGoogleOneTap(props: GoogleOneTapProps)` | ||
| - `Clerk.closeGoogleOneTap()` | ||
| ### Low level APIs for custom flows | ||
| - `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})` | ||
| - `await Clerk.handleGoogleOneTapCallback()` | ||
|
|
||
| We recommend using this two methods together in order and let Clerk to perform the correct redirections. | ||
| ```tsx | ||
| google.accounts.id.initialize({ | ||
| callback: async response => { | ||
| const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential}) | ||
| await Clerk.handleGoogleOneTapCallback(signInOrUp, { | ||
| signInForceRedirectUrl: window.location.href, | ||
| }) | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
| In case you want to handle the redirection and session management yourself you can do so like this | ||
| ```tsx | ||
| google.accounts.id.initialize({ | ||
| callback: async response => { | ||
| const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential}) | ||
| if(signInOrUp.status === 'complete') { | ||
| await Clerk.setActive({ | ||
| session: signInOrUp.createdSessionId | ||
| }) | ||
| } | ||
| }, | ||
| }); | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved to Clerk.ts