Skip to content

feat(tanstack-start): Introduce @clerk/tanstack-start - #3538

Merged
octoper merged 26 commits into
mainfrom
tanstack-start
Jun 11, 2024
Merged

feat(tanstack-start): Introduce @clerk/tanstack-start#3538
octoper merged 26 commits into
mainfrom
tanstack-start

Conversation

@octoper

@octoper octoper commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Description

Introducing an experimental version of Clerk SDK for TanStack Start.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Jun 7, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ebcedb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/tanstack-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper self-assigned this Jun 7, 2024
export const useAwaitableNavigate = () => {
const navigate = useNavigate();
const location = useLocation();
const resolveFunctionsRef = React.useRef<Resolve[]>([]);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper I remember explictly not using refs for awaitable navigate for nextjs. Is this case different ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed what we already have in the Remix SDK as it's similar

Comment thread packages/tanstack-start/tsup.config.ts Outdated
@octoper
octoper requested a review from nikosdouvlis June 7, 2024 16:23
@octoper
octoper marked this pull request as ready for review June 7, 2024 16:23
Comment thread packages/tanstack-start/tsup.config.ts Outdated
Comment thread packages/tanstack-start/src/utils/index.ts Outdated
Comment thread packages/tanstack-start/src/server/middlewareHandler.ts Outdated
Comment thread packages/tanstack-start/README.md Outdated
Comment thread packages/tanstack-start/src/client/ClerkProvider.tsx
@octoper
octoper requested a review from nikosdouvlis June 10, 2024 14:13

@nikosdouvlis nikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @octoper :)

@octoper
octoper enabled auto-merge (squash) June 11, 2024 10:14
@octoper
octoper merged commit d0b02e6 into main Jun 11, 2024
@octoper
octoper deleted the tanstack-start branch June 11, 2024 10:23
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants