fix(clerk-js): Allow wails protocol - #3564
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7ed726f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
marked this pull request as ready for review
June 13, 2024 12:21
anagstef
approved these changes
Jun 13, 2024
tmilewski
approved these changes
Jun 13, 2024
nikosdouvlis
approved these changes
Jun 13, 2024
This was referenced Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a previous release the protocol validation for window navigation was added (ref). Since then only
http:andhttps:were allowed. With this releasewails:is also supported again.We don't expect this allow list to be a maintenance burden since most people will use http/https protocols and it's the easiest way to ensure the security fix that the original commit introduced.
Fixes #3545
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change