fix(elements): Sign-in/up root fallbacks not rendering properly - #3601
Merged
Conversation
🦋 Changeset detectedLatest commit: abb94cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
!snapshot |
Collaborator
|
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/elements@0.8.1-snapshot.vabb94cc --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/ui@0.1.3-snapshot.vabb94cc --save-exact |
tmilewski
commented
Jun 20, 2024
| Sign In with Google | ||
| </Clerk.Connection> | ||
|
|
||
| <Clerk.Connection |
Member
Author
There was a problem hiding this comment.
Not used, per configuration
panteliselef
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sign in/up root fallbacks were still being held up by client-side requirements. This moves the logic such that this is no longer the case.
Fixes SDK-1842
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change