feat(chrome-extension): Poll for new active sessions - #3616
Merged
Conversation
🦋 Changeset detectedLatest commit: 88bc372 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
force-pushed
the
feat.chrome-ext/poll-for-active-session
branch
from
June 24, 2024 21:38
43ac39e to
88bc372
Compare
tmilewski
marked this pull request as ready for review
June 24, 2024 21:38
panteliselef
approved these changes
Jun 25, 2024
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
LGTM
- I wonder if we have checked that the opposite flow works. User logins to chrome extension and session is synced to website.
Member
Author
It's not possible in this fashion. We could, in theory, set the cookies to the permissioned domains from the extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Polls for active session changes allowing for synchronizing newly authenticated users after the extension has been opened.
Fixes SDK-1843
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change