fix(clerk-js): Update cache key for roles when organization changes - #3624
Merged
panteliselef merged 2 commits intoJun 26, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 8425c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
approved these changes
Jun 26, 2024
panteliselef
deleted the
elef/sdk-1822-should-refetch-roles-when-switching-organization
branch
June 26, 2024 12:53
dimkl
reviewed
Jun 26, 2024
| f.withOrganizations(); | ||
| f.withUser({ email_addresses: ['test@clerk.com'], organization_memberships: ['Org1', 'Org2'] }); | ||
| }); | ||
| fixtures.clerk.organization?.getRoles.mockRejectedValue(null); |
Contributor
There was a problem hiding this comment.
❓ @panteliselef Based on the ticket i think that we need to add a test to verify that different organization roles are displayed / fetched when the organization is switched.
The updated test does not seem to be related to that scenario.
| const { data, isLoading } = useFetch(enabled && !!organization?.id ? organization?.getRoles : undefined, { | ||
| ...getRolesParams, | ||
| orgId: organization?.id, | ||
| }); |
Contributor
There was a problem hiding this comment.
🙃 Do we populate the organization instance for personal account? If not i would expect to use enabled && !!organization instead. Eg:
const { data, isLoading } = useFetch(enabled && !!organization ? organization?.getRoles : undefined, {
...getRolesParams,
orgId: organization?.id,
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes SDK-1822
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change