fix(clerk-js): Clear session after deleting an account - #3628
Merged
octoper merged 7 commits intoJul 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 08f0d42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
!preview |
Collaborator
|
Hey @octoper, your preview is available.
|
Contributor
Author
|
!preview |
octoper
marked this pull request as ready for review
June 27, 2024 20:44
octoper
changed the title
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
💯 Seems like we were working on the same thing, sorry for not communicating it. I asked some questions mainly because i went with a different direction
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
from
June 28, 2024 15:40
02f53c5 to
3d05d89
Compare
Contributor
Author
|
!preview |
1 similar comment
Contributor
Author
|
!preview |
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
from
July 1, 2024 11:13
35446eb to
fe407fd
Compare
Contributor
Author
|
!preview |
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
2 times, most recently
from
July 1, 2024 15:26
d7f0e0a to
7c30128
Compare
dimkl
reviewed
Jul 1, 2024
| const navigationCallback = | ||
| otherSessions.length === 0 ? navigateAfterSignOut : navigateAfterMultiSessionSingleSignOutUrl; | ||
| return await setActive({ | ||
| session, |
Contributor
There was a problem hiding this comment.
⛔ We should not use the previous session since it's (probably) already deleted. We should pass { session: null }
dimkl
suggested changes
Jul 1, 2024
dimkl
left a comment
dimkl
left a comment
Contributor
There was a problem hiding this comment.
I have left some comments. Also we need to add a test to verify the expected behaviour!
panteliselef
approved these changes
Jul 1, 2024
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
LGTM, added a comment for an updated changeset
Contributor
Author
|
@dimkl Added the change and E2E tests as you suggested |
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
4 times, most recently
from
July 5, 2024 06:49
805a6c3 to
a837390
Compare
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
4 times, most recently
from
July 9, 2024 12:52
082b1c4 to
961ecdb
Compare
dimkl
approved these changes
Jul 10, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
octoper
force-pushed
the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
from
July 10, 2024 13:05
961ecdb to
08f0d42
Compare
octoper
deleted the
vaggelis/sdk-1825-deleting-a-users-account-does-not-clear-their-state-and
branch
July 10, 2024 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the session is not cleared correctly after deleting an account
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change