chore(astro): Remove duplicate logic in interactive components - #3664
Merged
wobsoriano merged 15 commits intoJul 5, 2024
Conversation
🦋 Changeset detectedLatest commit: 8e979eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
changed the title
wobsoriano
force-pushed
the
rob/eco-16-remove-duplication-in-interactive-components
branch
from
July 4, 2024 14:58
aeca5fb to
27594f0
Compare
wobsoriano
commented
Jul 4, 2024
wobsoriano
marked this pull request as ready for review
July 4, 2024 15:13
panteliselef
reviewed
Jul 5, 2024
Comment on lines
+11
to
+13
| const props = { | ||
| ...Astro.props, | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need this ? I think we are accessing Astro.props below directly
Member
Author
There was a problem hiding this comment.
Still using this in new update, but destructured since the component prop is not a clerk UI element option
wobsoriano
enabled auto-merge (squash)
July 5, 2024 19:46
wobsoriano
deleted the
rob/eco-16-remove-duplication-in-interactive-components
branch
July 5, 2024 20:13
wobsoriano
added a commit
that referenced
this pull request
Jul 5, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses ECO-16 by consolidating the logic of interactive components into a single component used across all of them.
As said in the initial Astro PR, playground and tests will follow.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change