Skip to content

fix(testing): Use @clerk/backend package to fetch tokens - #3667

Merged
anagstef merged 2 commits into
mainfrom
stefanos/use-backend-package-in-testing-package
Jul 5, 2024
Merged

fix(testing): Use @clerk/backend package to fetch tokens#3667
anagstef merged 2 commits into
mainfrom
stefanos/use-backend-package-in-testing-package

Conversation

@anagstef

@anagstef anagstef commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

Description

Drops the custom fetch to BAPI, and replaces it with using the @clerk/backend package.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Jul 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 69e0684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef
anagstef requested review from dimkl and octoper July 5, 2024 12:14
@anagstef anagstef self-assigned this Jul 5, 2024
@anagstef
anagstef marked this pull request as ready for review July 5, 2024 12:14
@anagstef

anagstef commented Jul 5, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/testing 1.1.10-snapshot.ve48d86f

Tip: Use the snippet copy button below to quickly install the required packages.
gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.ve48d86f --save-exact

@anagstef

anagstef commented Jul 5, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/testing 1.1.10-snapshot.v69e0684

Tip: Use the snippet copy button below to quickly install the required packages.
gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.v69e0684 --save-exact

@anagstef
anagstef merged commit 5f502bf into main Jul 5, 2024
@anagstef
anagstef deleted the stefanos/use-backend-package-in-testing-package branch July 5, 2024 13:21
@dimkl

dimkl commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

@anagstef What was the reason behind this change?

@anagstef

anagstef commented Jul 5, 2024

Copy link
Copy Markdown
Contributor Author

@dimkl Using our backend package is cleaner, instead of hitting our BAPI directly with a fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants