fix(elements): Correct TS types for verification machine - #3671
Merged
LekoArts merged 5 commits intoJul 9, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: e0e2dff The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
commented
Jul 8, 2024
| // https://www.notion.so/clerkdev/Implement-sign-in-alt-methods-e6e60ffb644645b3a0553b50556468ce | ||
| export function determineStartingSignInFactor( | ||
| firstFactors: SignInFactor[], | ||
| firstFactors: SignInFirstFactor[], |
Contributor
Author
There was a problem hiding this comment.
SignInFactor is SignInFirstFactor | SignInSecondFactor. The changes in this file narrow the input and return types
| loadingStep: 'verifications', | ||
| parent: input.parent, | ||
| registeredStrategies: new Set<SignInFactor>(), | ||
| registeredStrategies: new Set<SignInStrategyName>(), |
Contributor
Author
There was a problem hiding this comment.
This change stems from looking at packages/elements/src/react/sign-in/verifications.tsx and checking what is actually passed
LekoArts
marked this pull request as ready for review
July 8, 2024 14:08
alexcarpenter
approved these changes
Jul 8, 2024
panteliselef
approved these changes
Jul 8, 2024
…egy-verification-machine
LekoArts
enabled auto-merge (squash)
July 9, 2024 06:06
LekoArts
deleted the
lekoarts/sdk-1845-correct-ts-types-for-strategy-verification-machine
branch
July 9, 2024 06:16
wobsoriano
pushed a commit
that referenced
this pull request
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inside our verification machine we had a bunch of
as unknown as SignInFactorassertions and other inaccurate TS types. This PR fixes it 👍 See inline comments for more context.Fixes SDK-1845
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change