chore(astro): Optimize stream modification - #3673
Merged
wobsoriano merged 7 commits intoJul 9, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 0f5505d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
changed the title
wobsoriano
marked this pull request as ready for review
July 8, 2024 16:11
panteliselef
reviewed
Jul 8, 2024
| "@clerk/astro": patch | ||
| --- | ||
|
|
||
| Introduce `TransformStream` and work directly with encoded chunks when modifiying stream |
Contributor
There was a problem hiding this comment.
Generally we prefer to write more "product" oriented changesets when possilble. In this case I'd mentioned the performance boost, instead of mentioning the "how" with TransformStream
Member
Author
There was a problem hiding this comment.
I'll keep that in mind, thanks! and updated
…whole-response-stream-to
…whole-response-stream-to
…whole-response-stream-to
panteliselef
changed the title
wobsoriano
deleted the
rob/eco-19-invert-the-logic-of-decoding-the-whole-response-stream-to
branch
July 9, 2024 12:42
wobsoriano
added a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles ECO-19 and ECO-18 and optimizes stream modification by working directly with the
Uint8Arrayinstead of decoding and re-encoding a chunk to check for string (</head>) availability. IntroducesTransformStream.A benchmark between the current implementation and the proposed is available in this gist.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change