Skip to content

fix(astro): Accessing import.meta at build causes app to break #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 2 commits into from
Jul 8, 2024
Merged

fix(astro): Accessing import.meta at build causes app to break #3675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72e6039
fix(astro): Accessing import.meta at build causes app to break
panteliselef Jul 8, 2024
282cce2
fix(astro): Add changeset
panteliselef Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-icons-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/astro": patch
---

Bug fix: Removed import.meta from integration to avoid breaking app during build.
19 changes: 9 additions & 10 deletions packages/astro/src/integration/create-integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,6 @@ function createIntegration<P extends { mode: 'hotload' | 'bundled' }>({ mode }:
const clerkJSVariant = (params as any)?.clerkJSVariant as string | undefined;
const clerkJSVersion = (params as any)?.clerkJSVersion as string | undefined;

const internalParams: ClerkOptions = {
...params,
sdkMetadata: {
version: packageVersion,
name: packageName,
// eslint-disable-next-line turbo/no-undeclared-env-vars
environment: import.meta.env.MODE,
},
};

return {
name: '@clerk/astro/integration',
hooks: {
Expand All @@ -51,6 +41,15 @@ function createIntegration<P extends { mode: 'hotload' | 'bundled' }>({ mode }:
logger.error('Invalid value for clerkJSVariant. Acceptable values are `"headless"`, `""`, and `undefined`');
}

const internalParams: ClerkOptions = {
...params,
sdkMetadata: {
version: packageVersion,
name: packageName,
environment: command === 'dev' ? 'development' : 'production',
},
};

const defaultBundledImportPath = `${packageName}/internal/bundled`;

const buildImportPath =
Expand Down