Skip to content

feat(types,clerk-js): Introduce Custom OAuth providers - #3678

Merged
nikospapcom merged 3 commits into
mainfrom
nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript
Jul 15, 2024
Merged

feat(types,clerk-js): Introduce Custom OAuth providers#3678
nikospapcom merged 3 commits into
mainfrom
nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript

Conversation

@nikospapcom

@nikospapcom nikospapcom commented Jul 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR introduces custom OAuth provider support
Key changes include:

  • New types for custom OAuth providers and strategies
  • Modified social button to support providers without logos
  • New ProviderInitialIcon component for displaying provider initials

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@nikospapcom nikospapcom self-assigned this Jul 9, 2024
@changeset-bot

changeset-bot Bot commented Jul 9, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c63ced4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/astro Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcom

nikospapcom commented Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

clerk-cookie commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.vc876098
@clerk/backend 1.3.1-snapshot.vc876098
@clerk/chrome-extension 1.1.3-snapshot.vc876098
@clerk/clerk-js 5.8.1-snapshot.vc876098
@clerk/elements 0.10.2-snapshot.vc876098
@clerk/clerk-expo 1.2.6-snapshot.vc876098
@clerk/express 0.0.16-snapshot.vc876098
@clerk/fastify 1.0.18-snapshot.vc876098
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.8-snapshot.vc876098
@clerk/nextjs 5.2.3-snapshot.vc876098
@clerk/clerk-react 5.2.8-snapshot.vc876098
@clerk/remix 4.2.2-snapshot.vc876098
@clerk/clerk-sdk-node 5.0.15-snapshot.vc876098
@clerk/shared 2.3.3-snapshot.vc876098
@clerk/tanstack-start 0.1.6-snapshot.vc876098
@clerk/testing 1.1.10-snapshot.vc876098
@clerk/themes 2.1.12-snapshot.vc876098
@clerk/types 4.7.1-snapshot.vc876098
@clerk/ui 0.1.8-snapshot.vc876098

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vc876098 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vc876098 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vc876098 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.8.1-snapshot.vc876098 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vc876098 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vc876098 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vc876098 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vc876098 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vc876098 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vc876098 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vc876098 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vc876098 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vc876098 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vc876098 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vc876098 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vc876098 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vc876098 --save-exact

@clerk/types

npm i @clerk/types@4.7.1-snapshot.vc876098 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vc876098 --save-exact

@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch 2 times, most recently from bc3a76a to f5b9413 Compare July 10, 2024 07:34
@nikospapcom
nikospapcom marked this pull request as ready for review July 10, 2024 09:05
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 97dae2b to ce6e670 Compare July 10, 2024 09:08
@nikospapcom

nikospapcom commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

clerk-cookie commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.vce6e670
@clerk/backend 1.3.1-snapshot.vce6e670
@clerk/chrome-extension 1.1.3-snapshot.vce6e670
@clerk/clerk-js 5.8.1-snapshot.vce6e670
@clerk/elements 0.10.2-snapshot.vce6e670
@clerk/clerk-expo 1.2.6-snapshot.vce6e670
@clerk/express 0.0.16-snapshot.vce6e670
@clerk/fastify 1.0.18-snapshot.vce6e670
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.8-snapshot.vce6e670
@clerk/nextjs 5.2.3-snapshot.vce6e670
@clerk/clerk-react 5.2.8-snapshot.vce6e670
@clerk/remix 4.2.2-snapshot.vce6e670
@clerk/clerk-sdk-node 5.0.15-snapshot.vce6e670
@clerk/shared 2.3.3-snapshot.vce6e670
@clerk/tanstack-start 0.1.6-snapshot.vce6e670
@clerk/testing 1.1.10-snapshot.vce6e670
@clerk/themes 2.1.12-snapshot.vce6e670
@clerk/types 4.7.1-snapshot.vce6e670
@clerk/ui 0.1.8-snapshot.vce6e670

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vce6e670 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vce6e670 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vce6e670 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.8.1-snapshot.vce6e670 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vce6e670 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vce6e670 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vce6e670 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vce6e670 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vce6e670 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vce6e670 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vce6e670 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vce6e670 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vce6e670 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vce6e670 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vce6e670 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vce6e670 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vce6e670 --save-exact

@clerk/types

npm i @clerk/types@4.7.1-snapshot.vce6e670 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vce6e670 --save-exact

octoper
octoper reviewed Jul 10, 2024
View reviewed changes
Comment thread .changeset/unlucky-hornets-roll.md Outdated
Comment thread .changeset/unlucky-hornets-roll.md Outdated
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from ce6e670 to 2b99821 Compare July 10, 2024 09:33
octoper
octoper reviewed Jul 10, 2024
View reviewed changes
Comment thread packages/clerk-js/src/ui/hooks/__tests__/useEnabledThirdPartyProviders.test.tsx Outdated
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 2b99821 to 65c5fbc Compare July 10, 2024 09:36
octoper
octoper approved these changes Jul 10, 2024
View reviewed changes

@octoper octoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikospapcom
nikospapcom requested a review from dimkl July 10, 2024 09:40
anagstef
anagstef reviewed Jul 10, 2024
View reviewed changes
Comment thread .changeset/unlucky-hornets-roll.md Outdated
anagstef
anagstef reviewed Jul 10, 2024
View reviewed changes
Comment thread .changeset/unlucky-hornets-roll.md Outdated
anagstef
anagstef reviewed Jul 10, 2024
View reviewed changes
Comment thread .changeset/unlucky-hornets-roll.md Outdated
anagstef
anagstef reviewed Jul 10, 2024
View reviewed changes
Comment thread .changeset/unlucky-hornets-roll.md Outdated
panteliselef
panteliselef reviewed Jul 10, 2024
View reviewed changes
Comment thread packages/clerk-js/src/ui/components/UserProfile/ConnectedAccountsMenu.tsx Outdated
anagstef
anagstef reviewed Jul 10, 2024
View reviewed changes
Comment thread packages/clerk-js/src/ui/common/InitialIcon.tsx Outdated
anagstef
anagstef approved these changes Jul 10, 2024
View reviewed changes

@anagstef anagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but in general looks good! Great job!! 🚀

panteliselef
panteliselef reviewed Jul 10, 2024
View reviewed changes
Comment thread packages/clerk-js/src/ui/common/InitialIcon.tsx Outdated
Comment thread packages/clerk-js/src/ui/common/InitialIcon.tsx Outdated
Comment thread packages/clerk-js/src/ui/hooks/useEnabledThirdPartyProviders.tsx Outdated
Comment thread packages/clerk-js/src/ui/hooks/useEnabledThirdPartyProviders.tsx Outdated
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch 2 times, most recently from ac07f7a to 7b4599b Compare July 10, 2024 11:12
panteliselef
panteliselef approved these changes Jul 10, 2024
View reviewed changes

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment thread .changeset/unlucky-hornets-roll.md Outdated
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 98f9182 to f154a27 Compare July 10, 2024 12:46
@nikospapcom

nikospapcom commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

clerk-cookie commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.vf154a27
@clerk/backend 1.3.1-snapshot.vf154a27
@clerk/chrome-extension 1.1.3-snapshot.vf154a27
@clerk/clerk-js 5.9.0-snapshot.vf154a27
@clerk/elements 0.10.2-snapshot.vf154a27
@clerk/clerk-expo 1.2.6-snapshot.vf154a27
@clerk/express 0.0.16-snapshot.vf154a27
@clerk/fastify 1.0.18-snapshot.vf154a27
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.8-snapshot.vf154a27
@clerk/nextjs 5.2.3-snapshot.vf154a27
@clerk/clerk-react 5.2.8-snapshot.vf154a27
@clerk/remix 4.2.2-snapshot.vf154a27
@clerk/clerk-sdk-node 5.0.15-snapshot.vf154a27
@clerk/shared 2.3.3-snapshot.vf154a27
@clerk/tanstack-start 0.1.6-snapshot.vf154a27
@clerk/testing 1.1.10-snapshot.vf154a27
@clerk/themes 2.1.12-snapshot.vf154a27
@clerk/types 4.8.0-snapshot.vf154a27
@clerk/ui 0.1.8-snapshot.vf154a27

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vf154a27 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vf154a27 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vf154a27 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.9.0-snapshot.vf154a27 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vf154a27 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vf154a27 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vf154a27 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vf154a27 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vf154a27 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vf154a27 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vf154a27 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vf154a27 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vf154a27 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vf154a27 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vf154a27 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vf154a27 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vf154a27 --save-exact

@clerk/types

npm i @clerk/types@4.8.0-snapshot.vf154a27 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vf154a27 --save-exact

@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from f7a007f to e553bcc Compare July 12, 2024 06:56
@nikospapcom
nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from e553bcc to c63ced4 Compare July 15, 2024 06:01
@nikospapcom
nikospapcom merged commit 0935cfc into main Jul 15, 2024
@nikospapcom
nikospapcom deleted the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch July 15, 2024 10:38
@clerk-cookie clerk-cookie mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nikpolik Nikpolik Awaiting requested review from Nikpolik
@kostaspt kostaspt Awaiting requested review from kostaspt
@nikosdouvlis nikosdouvlis Awaiting requested review from nikosdouvlis
@dimkl dimkl Awaiting requested review from dimkl
3 more reviewers
@octoper octoper octoper approved these changes
@anagstef anagstef anagstef approved these changes
@panteliselef panteliselef panteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nikospapcom nikospapcom

Labels

clerk-js types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikospapcom @clerk-cookie @octoper @anagstef @panteliselef