chore(astro): Drop convenience Astro wrappers for React - #3682
Merged
Conversation
🦋 Changeset detectedLatest commit: 32032bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
changed the title
wobsoriano
changed the title
wobsoriano
changed the title
wobsoriano
marked this pull request as ready for review
July 10, 2024 01:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have 3 ways of importing Astro/React Clerk components (docs WIP):
import { } from '@clerk/astro/components/{control|interactive|unstyled}'- Fully Astro components.import { } from '@clerk/astro/client/react'- React components. Needs theclient:loaddirective when imported in an Astro component to be hydrated.import { } from '@clerk/astro/components/react- Astro components that wrap option 2 with theclient:loaddirective for convenience.Multiple import methods can confuse users. Some features, like the
asChildprop for unstyled components, don't work when React components are used in Astro due to Astro's slot system and islands architecture. As a result, we're discontinuing option 3.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change