chore(e2e): Test control components for Astro and Astro + React - #3693
Merged
panteliselef merged 4 commits intoJul 12, 2024
Merged
Conversation
This commit also changes `astro.node.withEmailCodes` to `astro.node.withCustomRoles`. Additionally the `withCustomRoles` now will use the production Backend API
🦋 Changeset detectedLatest commit: 6ed3c6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
reviewed
Jul 12, 2024
| import { $userStore } from '@clerk/astro/client/stores'; | ||
|
|
||
| export function PageWithUser({ children }: PropsWithChildren) { | ||
| const user = useSyncExternalStore($userStore.listen, $userStore.get, $userStore.get); |
Member
There was a problem hiding this comment.
Could we use the custom store hook that was previously created for this? Or is the intentional?
Contributor
Author
There was a problem hiding this comment.
We are not exporting that in user land tho. I would expect people that use @clerk/astro to create their own hook or use @nanostores/react. In the future we could have useUser exported from @clerk/astro
nikosdouvlis
approved these changes
Jul 12, 2024
…ith-the-react-components
panteliselef
enabled auto-merge (squash)
July 12, 2024 09:47
panteliselef
deleted the
elef/eco-25-add-e2e-tests-with-basic-flows-with-the-react-components
branch
July 12, 2024 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR also changes
astro.node.withEmailCodestoastro.node.withCustomRoles. Additionally thewithCustomRolesnow will use the production Backend APIChecklist
npm testruns as expected.npm run buildruns as expected.Type of change