chore(astro): Move safe id generation to a shared function - #3698
Merged
LekoArts merged 3 commits intoJul 12, 2024
Conversation
🦋 Changeset detectedLatest commit: da25f2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
marked this pull request as ready for review
July 11, 2024 23:02
anagstef
approved these changes
Jul 12, 2024
dimkl
reviewed
Jul 12, 2024
dimkl
approved these changes
Jul 12, 2024
panteliselef
approved these changes
Jul 12, 2024
LekoArts
enabled auto-merge (squash)
July 12, 2024 11:04
LekoArts
deleted the
rob/eco-22-move-safe-id-generation-to-a-shared-function
branch
July 12, 2024 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles ECO-22 and consolidates ID generation with a custom utility function
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change