chore(astro): Simplify submodules and drop bundled variant - #3701
Merged
panteliselef merged 4 commits intoJul 12, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 2dd9cdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
elef/eco-32-simplify-submodules-and-drop-bundled-variant
branch
from
July 12, 2024 13:18
8e420ba to
a62d8ff
Compare
panteliselef
marked this pull request as ready for review
July 12, 2024 15:48
Contributor
Author
|
!snapshot |
Collaborator
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@0.0.3-snapshot.va62d8ff --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact |
octoper
reviewed
Jul 12, 2024
| "types": "./dist/react/index.d.ts", | ||
| "import": "./dist/react/index.js" | ||
| }, | ||
| "./client/stores": { |
Contributor
There was a problem hiding this comment.
❓ Are we going to keep /client/stores as a separate export?
Why don't we merge it into /client?
Contributor
Author
There was a problem hiding this comment.
hmmm, i think we can do that yeah. @wobsoriano WDYT ?
Member
There was a problem hiding this comment.
It makes sense since:
- They will know it should only be used in
client - We have a
storesuffix (i.e.$authStore) so they will know immediately that it is a nanostore
panteliselef
enabled auto-merge (squash)
July 12, 2024 17:42
panteliselef
deleted the
elef/eco-32-simplify-submodules-and-drop-bundled-variant
branch
July 12, 2024 17:51
wobsoriano
pushed a commit
that referenced
this pull request
Jul 12, 2024
wobsoriano
pushed a commit
that referenced
this pull request
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify submodules and drop the
bunldedvariant.Moved
@clerk/astro/client/reactto@clerk/astro/reactDropped
@clerk/astro/bundled@clerk/astro/client/bundled@clerk/astro/internal/bundled@clerk/astro/integration@clerk/astro/integration/bundledChecklist
npm testruns as expected.npm run buildruns as expected.Type of change