Skip to content

fix(elements): ensure updated provided values are sent to the machine #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 4 commits into from
Jul 15, 2024
Merged

fix(elements): ensure updated provided values are sent to the machine #3702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fc8064
ensure updated provided values are sent to the machine
alexcarpenter Jul 12, 2024
a717e02
add changeset
alexcarpenter Jul 12, 2024
8ede248
Merge branch 'main' into alexcarpenter/sdki-136-ensure-controlled-inp…
tmilewski Jul 15, 2024
0e342a0
Merge branch 'main' into alexcarpenter/sdki-136-ensure-controlled-inp…
alexcarpenter Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-chairs-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/elements": patch
---

Ensure updated provided values to controlled inputs are sent to the machine
14 changes: 7 additions & 7 deletions packages/elements/src/react/common/form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ const useField = ({ name }: Partial<Pick<FieldDetails, 'name'>>) => {

const useInput = ({
name: inputName,
value: initialValue,
value: providedValue,
type: inputType,
onChange: onChangeProp,
onBlur: onBlurProp,
Expand Down Expand Up @@ -265,7 +265,7 @@ const useInput = ({
return;
}

ref.send({ type: 'FIELD.ADD', field: { name, value: initialValue } });
ref.send({ type: 'FIELD.ADD', field: { name, value: providedValue } });

return () => ref.send({ type: 'FIELD.REMOVE', field: { name } });
}, [ref]); // eslint-disable-line react-hooks/exhaustive-deps
Expand All @@ -274,15 +274,15 @@ const useInput = ({
const onChange = React.useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
onChangeProp?.(event);
if (!name || initialValue) {
if (!name) {
return;
}
ref.send({ type: 'FIELD.UPDATE', field: { name, value: event.target.value } });
if (shouldValidatePassword) {
validatePassword(event.target.value);
}
},
[ref, name, onChangeProp, initialValue, shouldValidatePassword, validatePassword],
[ref, name, onChangeProp, shouldValidatePassword, validatePassword],
);

const onBlur = React.useCallback(
Expand All @@ -306,11 +306,11 @@ const useInput = ({
);

React.useEffect(() => {
if (!initialValue || !name) {
if (!name) {
return;
}
ref.send({ type: 'FIELD.UPDATE', field: { name, value: initialValue } });
}, [name, ref, initialValue]);
ref.send({ type: 'FIELD.UPDATE', field: { name, value: providedValue } });
}, [name, ref, providedValue]);

// TODO: Implement clerk-js utils
const shouldBeHidden = false;
Expand Down