fix(elements): Add check for authenticable web3 strategy - #3708
Merged
alexcarpenter merged 6 commits intoJul 15, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: c41966c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
changed the title
alexcarpenter
marked this pull request as ready for review
July 12, 2024 20:51
…ds-to-runtime-error
…ds-to-runtime-error
alexcarpenter
enabled auto-merge (squash)
July 15, 2024 15:40
…ds-to-runtime-error
alexcarpenter
deleted the
alexcarpenter/sdki-138-enabling-metamask-leads-to-runtime-error
branch
July 15, 2024 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue in
isWeb3Strategycheck to account forweb3_prefix in provider name. This was causing a runtime error to be thrown when enabling metamask.BEFORE
AFTER
https://linear.app/clerk/issue/SDKI-138/enabling-metamask-leads-to-runtime-error
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change