Skip to content

fix(clerk-js): Passkeys should not be a candidate for the dynamic fie… - #3920

Merged
EmmanouelaPothitou merged 2 commits into
release/v4from
emmanouela/user-515-missing-link-to-switch-back-to-email-on-the-signin-component
Aug 9, 2024
Merged

fix(clerk-js): Passkeys should not be a candidate for the dynamic fie…#3920
EmmanouelaPothitou merged 2 commits into
release/v4from
emmanouela/user-515-missing-link-to-switch-back-to-email-on-the-signin-component

Conversation

@EmmanouelaPothitou

@EmmanouelaPothitou EmmanouelaPothitou commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

…ld (v4)

Description

Passkeys should not be a candidate for the dynamic field.
Allow users to display the email address field after selecting to input a phone number. Previously that was not possible when passkeys were enabled.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@EmmanouelaPothitou
EmmanouelaPothitou requested a review from a team as a code owner August 8, 2024 15:45
@changeset-bot

changeset-bot Bot commented Aug 8, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8b9b474

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we forgot to backport this one, nice work

@EmmanouelaPothitou
EmmanouelaPothitou merged commit f18ca13 into release/v4 Aug 9, 2024
@EmmanouelaPothitou
EmmanouelaPothitou deleted the emmanouela/user-515-missing-link-to-switch-back-to-email-on-the-signin-component branch August 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants