fix(tanstack-start): Fix bug for getAuth - #4019
Conversation
🦋 Changeset detectedLatest commit: 41d1e88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@1.2.1-snapshot.vf6cf34f --save-exact
npm i @clerk/backend@1.8.1-snapshot.vf6cf34f --save-exact
npm i @clerk/chrome-extension@1.2.4-snapshot.vf6cf34f --save-exact
npm i @clerk/clerk-js@5.16.0-snapshot.vf6cf34f --save-exact
npm i @clerk/elements@0.14.1-snapshot.vf6cf34f --save-exact
npm i @clerk/clerk-expo@2.2.2-snapshot.vf6cf34f --save-exact
npm i @clerk/express@0.0.31-snapshot.vf6cf34f --save-exact
npm i @clerk/fastify@1.0.33-snapshot.vf6cf34f --save-exact
npm i @clerk/localizations@2.6.2-snapshot.vf6cf34f --save-exact
npm i @clerk/nextjs@5.3.4-snapshot.vf6cf34f --save-exact
npm i @clerk/clerk-react@5.4.3-snapshot.vf6cf34f --save-exact
npm i @clerk/remix@4.2.17-snapshot.vf6cf34f --save-exact
npm i @clerk/clerk-sdk-node@5.0.30-snapshot.vf6cf34f --save-exact
npm i @clerk/shared@2.5.3-snapshot.vf6cf34f --save-exact
npm i @clerk/tanstack-start@0.3.0-snapshot.vf6cf34f --save-exact
npm i @clerk/testing@1.2.13-snapshot.vf6cf34f --save-exact
npm i @clerk/themes@2.1.22-snapshot.vf6cf34f --save-exact
npm i @clerk/types@4.15.0-snapshot.vf6cf34f --save-exact |
| * https://github.com/whatwg/fetch/pull/1457 | ||
| * @internal | ||
| */ | ||
| export const patchRequest = (request: Request) => { |
There was a problem hiding this comment.
@octoper Would it make sense or is it possible to have this be part of createClerkRequest ?
I remember having to do something similar for remix.
There was a problem hiding this comment.
Yeah need we need to revise it in the @clerk/backend how we handle request, I will add ticket so we can have a better look at it
There was a problem hiding this comment.
Curious if adding this to createClerkRequest would break other SDKs like Next
There was a problem hiding this comment.
Yeah, I was not sure about it, I created a ticket so we can have a better look at it and have one solution for everything
293a7aa to
d5b762c
Compare
d5b762c to
41d1e88
Compare
Description
This PR fixes a bug occurred when using
getAuthin multiple server functionsChecklist
npm testruns as expected.npm run buildruns as expected.Type of change