chore(repo): Node 20 / attw change - #4283
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 797764f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
changed the title
LekoArts
marked this pull request as ready for review
October 4, 2024 10:38
nikosdouvlis
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #4270 I'm changing the
engines.nodeof Fastify to Node.js 20. Then CI failed because it runs on Node 18 by default. I changed one step (linting) to use Node 20 but for the init action for other steps (like Node 18 unit tests) I had to use theengine-strictflag. (So if we'd want I could change back the Node 20 change as I later discovered).CI in above PR then failed for
attwandbundlewatchissues, since the former failed/timed-out somewhere and the latter was missing as a dep.Since
attwin CI and locally were different, I moved the source of truth (ignoring certain issues) to thepackage.jsonof each package, so that bothnpm run lint:attwis the same locally and in CI.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change