Skip to content

fix(elements): Remove example mode guard from passkey event in verification flow #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmilewski merged 2 commits into from
Oct 8, 2024
Merged

fix(elements): Remove example mode guard from passkey event in verification flow #4295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18bf041
fix(elements): Remove example mode guard from passkey event in
tmilewski Oct 7, 2024
563b9ea
Fix auto-formatting
tmilewski Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-adults-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/elements": patch
---

Remove "example mode" guard form "AUTHENICTATE.PASSKEY" event in verification flow
5 changes: 2 additions & 3 deletions packages/elements/src/internals/machines/sign-in/verification.machine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type {
Web3Attempt,
} from '@clerk/types';
import type { DoneActorEvent } from 'xstate';
import { assign, fromPromise, log, not, sendTo, setup } from 'xstate';
import { assign, fromPromise, log, sendTo, setup } from 'xstate';

import {
MAGIC_LINK_VERIFY_PATH_ROUTE,
Expand Down Expand Up @@ -270,7 +270,6 @@ const SignInVerificationMachine = setup({
description: 'Waiting for user input',
on: {
'AUTHENTICATE.PASSKEY': {
guard: not('isExampleMode'),
target: 'AttemptingPasskey',
reenter: true,
},
Expand Down Expand Up @@ -411,7 +410,7 @@ export const SignInFirstFactorMachine = SignInVerificationMachine.provide({
// prepareFirstFactor, we need to assert that the input is a PrepareFirstFactor. For some reason, ESLint thinks
// the assertion is unnecessary, and will remove it during the pre-commit hook. To prevent that, we disable the
// rule for the line.
// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion

const { params, parent, resendable } = input as PrepareFirstFactorInput;
const clerk = parent.getSnapshot().context.clerk;

Expand Down