Skip to content

fix(nextjs): Include protect types in auth - #4398

Merged
panteliselef merged 3 commits into
mainfrom
elef/fix-protect-v6-types
Oct 24, 2024
Merged

fix(nextjs): Include protect types in auth#4398
panteliselef merged 3 commits into
mainfrom
elef/fix-protect-v6-types

Conversation

@panteliselef

@panteliselef panteliselef commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Description

During #4366 we typed the arguments of protect() for page/route/action as any

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 23, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cd413e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef
panteliselef requested a review from a team October 23, 2024 20:21
@panteliselef panteliselef self-assigned this Oct 23, 2024
Comment thread packages/nextjs/src/app-router/server/auth.ts Outdated

@jacekradko jacekradko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🙇🏼

@panteliselef
panteliselef merged commit e8ccb55 into main Oct 24, 2024
@panteliselef
panteliselef deleted the elef/fix-protect-v6-types branch October 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants