chore(vue): Remove customPages prop types from UI components#5101
Merged
Conversation
🦋 Changeset detectedLatest commit: 04c014d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
wobsoriano
marked this pull request as ready for review
February 7, 2025 16:40
octoper
reviewed
Feb 7, 2025
| import { useUserProfileCustomPages } from '../../../utils/useCustomPages'; | ||
| import { useUserButtonCustomMenuItems } from '../../../utils/useCustomMenuItems'; | ||
|
|
||
| type Props = Omit<UserButtonProps, 'customMenuItems'>; |
Contributor
There was a problem hiding this comment.
❓ Why did we not omit customMenuItems now?
Member
Author
There was a problem hiding this comment.
Oh good catch, def missed that
octoper
approved these changes
Feb 7, 2025
wobsoriano
enabled auto-merge (squash)
February 7, 2025 16:51
wobsoriano
added a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small PR that removes the
customPagestype from props of<UserProfile />and<OrganizationProfile />and<UserButton />. We already do this at runtime, but this change makes it explicit in the type definitions to avoid confusion.We use slots to pass custom pages 👍🏼 This is non-breaking.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change