Skip to content

fix(upgrade): Remove unused getMajorVersion function #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosdouvlis merged 3 commits into from
Feb 12, 2025
Merged

fix(upgrade): Remove unused getMajorVersion function #5138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
241c7e6
initial
LekoArts Feb 12, 2025
40bee58
add changeset
LekoArts Feb 12, 2025
0469244
Merge branch 'main' into lekoarts/eco-403-clerkupgrade-error-in-unuse…
nikosdouvlis Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-moose-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/upgrade': patch
---

Remove an internal function that was executed but its return value wasn't used. In some instances this function threw an error.
9 changes: 0 additions & 9 deletions packages/upgrade/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Header } from './components/Header.js';
import { Scan } from './components/Scan.js';
import { SDKWorkflow } from './components/SDKWorkflow.js';
import SDKS from './constants/sdks.js';
import { getClerkMajorVersion } from './util/get-clerk-version.js';
import guessFrameworks from './util/guess-framework.js';

/**
Expand Down Expand Up @@ -34,15 +33,13 @@ export default function App(props) {
const [sdkGuessConfirmed, setSdkGuessConfirmed] = useState(false);
const [sdkGuessAttempted, setSdkGuessAttempted] = useState(false);
const [fromVersion, setFromVersion] = useState(props.fromVersion);
const [fromVersionGuessAttempted, setFromVersionGuessAttempted] = useState(false);

const [toVersion, setToVersion] = useState(props.toVersion);
const [dir, setDir] = useState(props.dir);
const [ignore, setIgnore] = useState(props.ignore ?? []);
const [configComplete, setConfigComplete] = useState(false);
const [configVerified, setConfigVerified] = useState(false);
const [uuid, setUuid] = useState();
let fromVersionGuess = false;

@LekoArts LekoArts Feb 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used anywhere, so dead code! This is because further down the file there are commented out code bits but I'm sure they are obsolete now, too


if (yolo) {
setSdks(SDKS.map(s => s.value));
Expand Down Expand Up @@ -77,12 +74,6 @@ export default function App(props) {
setSdkGuessAttempted(true);
}

// We try to guess which version of Clerk they are using
if (isEmpty(sdks) && !fromVersion && !fromVersionGuess && !fromVersionGuessAttempted) {
fromVersionGuess = getClerkMajorVersion();
setFromVersionGuessAttempted(true);
}

// No support for v3 or below, sadly
if (parseInt(fromVersion) < 4) {
return <Text color='red'>We're so sorry, but this tool only supports migration from version 4 and above.</Text>;
Expand Down
6 changes: 0 additions & 6 deletions packages/upgrade/src/util/get-clerk-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { readPackageSync } from 'read-pkg';
import semverRegex from 'semver-regex';

export function getClerkMajorVersion() {
const pkg = readPackageSync();
const clerk = pkg.dependencies.clerk;
return clerk ? semverRegex().exec(clerk)[0][0] : false;
}

export function getClerkSdkVersion(sdk) {
const pkg = readPackageSync();
const clerkSdk = pkg.dependencies[`@clerk/${sdk}`];
Expand Down