fix(shared): Preserve import.meta without requiring ES2020 target#5203
Closed
wobsoriano wants to merge 8 commits into
Closed
fix(shared): Preserve import.meta without requiring ES2020 target#5203wobsoriano wants to merge 8 commits into
import.meta without requiring ES2020 target#5203wobsoriano wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: 322f1b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
!snapshot |
Collaborator
|
Hey @wobsoriano - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/agent-toolkit@0.0.4-snapshot.v20250220050105 --save-exact
npm i @clerk/astro@2.3.0-snapshot.v20250220050105 --save-exact
npm i @clerk/backend@1.24.3-snapshot.v20250220050105 --save-exact
npm i @clerk/chrome-extension@2.2.11-snapshot.v20250220050105 --save-exact
npm i @clerk/clerk-js@5.54.0-snapshot.v20250220050105 --save-exact
npm i @clerk/elements@0.23.0-snapshot.v20250220050105 --save-exact
npm i @clerk/clerk-expo@2.8.0-snapshot.v20250220050105 --save-exact
npm i @clerk/expo-passkeys@0.1.22-snapshot.v20250220050105 --save-exact
npm i @clerk/express@1.3.50-snapshot.v20250220050105 --save-exact
npm i @clerk/fastify@2.1.23-snapshot.v20250220050105 --save-exact
npm i @clerk/localizations@3.10.8-snapshot.v20250220050105 --save-exact
npm i @clerk/nextjs@6.12.1-snapshot.v20250220050105 --save-exact
npm i @clerk/nuxt@1.2.1-snapshot.v20250220050105 --save-exact
npm i @clerk/clerk-react@5.24.0-snapshot.v20250220050105 --save-exact
npm i @clerk/react-router@1.1.1-snapshot.v20250220050105 --save-exact
npm i @clerk/remix@4.5.1-snapshot.v20250220050105 --save-exact
npm i @clerk/shared@2.23.0-snapshot.v20250220050105 --save-exact
npm i @clerk/tanstack-start@0.10.1-snapshot.v20250220050105 --save-exact
npm i @clerk/testing@1.4.24-snapshot.v20250220050105 --save-exact
npm i @clerk/themes@2.2.20-snapshot.v20250220050105 --save-exact
npm i @clerk/types@4.47.0-snapshot.v20250220050105 --save-exact
npm i @clerk/ui@0.3.25-snapshot.v20250220050105 --save-exact
npm i @clerk/vue@1.3.0-snapshot.v20250220050105 --save-exact |
wobsoriano
commented
Feb 20, 2025
| const text = new TextDecoder().decode(contents); | ||
|
|
||
| // Remove esbuild's var import_meta = {} transformation and restore original import.meta references | ||
| const modified = text.replace(/var\s+import_meta\s*=\s*{};/g, '').replace(/import_meta/g, 'import.meta'); |
Member
Author
There was a problem hiding this comment.
This restores the original import.meta references
Example built file:
without the plugin and ES2020 target, it gets transformed to:
var import_meta = {};
// ... other code
if (typeof import_meta !== "undefined" && import_meta.env && typeof import_meta.env[name] === "string") {
return import_meta.env[name];
}
wobsoriano
marked this pull request as ready for review
February 20, 2025 05:14
wobsoriano
commented
Feb 20, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@clerk/shared": minor | |||
Member
Author
There was a problem hiding this comment.
Since we're removing the target...
Member
Author
|
Closing this as we want to keep the state of the shared package and fix the issue in clerk-js side instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #4985, we introduced a shared function that checks if environment variables exist across different platforms (Node.js, Vite, Cloudflare, etc). To support Vite's
import.meta.env, we set the build target toES2020, but this broke support for older browsers due to ES2020 features like optional chaining.This PR removes the added ES2020 target, but preserves the
import.metafunctionality via a plugin. The plugin removes esbuild'svar import_meta = {}transformation and restores the originalimport.metareferences in ESM builds only, while maintaining compatibility with older browsers.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change